Re: Make pg_dump suppress COMMENT ON SCHEMA public ?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Make pg_dump suppress COMMENT ON SCHEMA public ?
Date: 2008-01-13 17:31:49
Message-ID: 478A4B05.5010406@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Could we dump it when it's non-default only? That way the people that
>> *have* set a custom comment on it will still get it restored, just a
>> failure in this case. The majority of people who *haven't* set a comment
>> will not have the problem at all.
>
> The patch seems ugly enough without wiring in knowledge of what the
> standard comment is :-(

I guess...

> We don't dump non-default comments on other system objects either,
> so I don't think it's out of line to suppress the one on schema public.

The distinction then is if "public" is actually a system object. I
would've considered it a non-system object, just that it happens to be
created by default.

Anyway. I don't see it as a big point - as long as we make sure it's
documented in some way somewhere. I doubt any application would actually
fail or have any kind of real problems because we miss the comment on
the public schema.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-01-13 17:56:57 Re: Make pg_dump suppress COMMENT ON SCHEMA public ?
Previous Message Tom Lane 2008-01-13 17:21:34 Re: timestamp refactor effort