Re: xact_desc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: xact_desc
Date: 2008-10-14 03:05:47
Message-ID: 5820.1223953547@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> ISTM that xact_desc routines do not work properly when called with
> WAL_DEBUG enabled from XLogInsert().

Well, now that you mention it, that code is utterly, completely broken,
and always has been. It's passing only the first rdata-chunk of the WAL
record to the print routine :-(

AFAICS the only way to fix it would be to allocate some workspace and
assemble the chunks of the record into that. Doubtful that it's worth
it --- I'd be inclined to just remove the code instead.

regards, tom lane

In response to

  • xact_desc at 2008-10-14 02:23:02 from Simon Riggs

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2008-10-14 03:35:57 Re: Updates of SE-PostgreSQL 8.4devel patches
Previous Message Simon Riggs 2008-10-14 02:23:02 xact_desc