| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: xact_desc |
| Date: | 2008-10-14 07:54:27 |
| Message-ID: | 1223970867.7007.481.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2008-10-13 at 23:05 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > ISTM that xact_desc routines do not work properly when called with
> > WAL_DEBUG enabled from XLogInsert().
>
> Well, now that you mention it, that code is utterly, completely broken,
> and always has been. It's passing only the first rdata-chunk of the WAL
> record to the print routine :-(
>
> AFAICS the only way to fix it would be to allocate some workspace and
> assemble the chunks of the record into that. Doubtful that it's worth
> it --- I'd be inclined to just remove the code instead.
Will remove, with extreme prejudice.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2008-10-14 08:34:37 | Is autovacuum too noisy about orphan temp tables? |
| Previous Message | Dave Page | 2008-10-14 07:37:46 | Re: 8.3 .4 + Vista + MingW + initdb = ACCESS_DENIED |