| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ATSimpleRecursion() and inheritance foreign parents |
| Date: | 2015-04-30 07:55:50 |
| Message-ID: | 5541E006.1090600@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/04/29 4:35, Tom Lane wrote:
> Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> On 2015/04/28 15:17, Amit Langote wrote:
>>> The code at the beginning of ATSimpleRecursion() looks like -
>>> if (recurse && rel->rd_rel->relkind == RELKIND_RELATION)
>>> Not sure if it's great idea, but now that foreign tables can also have
>>> children, should above be changed to take that into account?
>
>> Yeah, I think we should now allow the recursion for inheritance parents
>> that are foreign tables as well. Attached is a patch for that.
>
> Yeah, this is just an oversight. Fix pushed, and also a similar fix in
> parse_utilcmd.c.
Thanks!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2015-04-30 07:57:03 | Re: PL/pgSQL, RAISE and error context |
| Previous Message | Magnus Hagander | 2015-04-30 07:53:10 | Re: Minor typo in doc: replication-origins.sgml |