| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ATSimpleRecursion() and inheritance foreign parents |
| Date: | 2015-04-28 19:35:55 |
| Message-ID: | 34270.1430249755@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> On 2015/04/28 15:17, Amit Langote wrote:
>> The code at the beginning of ATSimpleRecursion() looks like -
>> if (recurse && rel->rd_rel->relkind == RELKIND_RELATION)
>> Not sure if it's great idea, but now that foreign tables can also have
>> children, should above be changed to take that into account?
> Yeah, I think we should now allow the recursion for inheritance parents
> that are foreign tables as well. Attached is a patch for that.
Yeah, this is just an oversight. Fix pushed, and also a similar fix in
parse_utilcmd.c. I thought I'd reviewed all the references to
RELKIND_RELATION before, but evidently I missed these.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-04-28 19:40:38 | Re: INSERT ... ON CONFLICT syntax issues |
| Previous Message | Bruce Momjian | 2015-04-28 19:35:39 | COPY and file_fdw with fixed column widths |