Re: what to do about unsupported encodings

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> pg_get_encoding_from_locale() in chklocale.c reports this when it finds
> a locale with an encoding it does not recognize:

> ereport(WARNING,
> (errmsg("could not determine encoding for locale \"%s\": codeset
> is \"%s\"",
> ctype, sys),
> errdetail("Please report this to <pgsql-bugs(at)postgresql(dot)org>.")));

> I guess we don't get many of these reports. But when testing out all
> the locales that an OS provides, I can produce tons of warnings like
> this, mostly related to legacy encodings of various localities.

> Should we maintain a list to the effect of, these are encodings we have
> heard about but don't support? Or should we just drop the "please
> report this" part? I think the latter was added when we were still
> breaking in this code, but it seems to have held up well.

I agree we could do without that now.

Slightly related: there are some callers such as PGLC_localeconv that
aren't checking for a failure return. Seems bad.

regards, tom lane