what to do about unsupported encodings

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: what to do about unsupported encodings
Date: 2016-10-26 16:04:55
Message-ID: 441fa05b-a70f-b26d-30b1-368706000514@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

pg_get_encoding_from_locale() in chklocale.c reports this when it finds
a locale with an encoding it does not recognize:

ereport(WARNING,
(errmsg("could not determine encoding for locale \"%s\": codeset
is \"%s\"",
ctype, sys),
errdetail("Please report this to <pgsql-bugs(at)postgresql(dot)org>.")));

I guess we don't get many of these reports. But when testing out all
the locales that an OS provides, I can produce tons of warnings like
this, mostly related to legacy encodings of various localities.

Should we maintain a list to the effect of, these are encodings we have
heard about but don't support? Or should we just drop the "please
report this" part? I think the latter was added when we were still
breaking in this code, but it seems to have held up well.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Serge Rielau 2016-10-26 16:22:07 Re: Fast Default WIP patch for discussion
Previous Message Peter Geoghegan 2016-10-26 16:02:21 Re: Parallel tuplesort (for parallel B-Tree index creation)