Re: CLUSTER VERBOSE (9.1.3)

From: Larry Rosenman <ler(at)lerctr(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CLUSTER VERBOSE (9.1.3)
Date: 2012-03-07 20:53:37
Message-ID: 4F57CAD1.3020301@lerctr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/7/2012 2:42 PM, Tom Lane wrote:
> Larry Rosenman <ler(at)lerctr(dot)org> writes:
>> On 3/7/2012 12:31 PM, Alvaro Herrera wrote:
>>> Also, this isn't limited to CLUSTER; anything that rewrites
>>> the table and indexes would benefit. Meaning ALTER TABLE that
>>> does a full rewrite, and also VACUUM FULL.
>
>> +1. I think we should update ps_status as well as
>> pg_stat_activity as all of these table rewrite processes are
>> running.
>
> -1. Updating ps_status is expensive, seriously so on some
> platforms. We could likely get away with tracking progress in
> pg_stat_activity though.
>
> However, this just reminds me that tracking intrastatement progress
> in pg_stat_activity has been discussed before and not much has
> happened. Let's please not have a quick kluge that just addresses
> CLUSTER and not any of the other aspects of that problem.
>
> regards, tom lane
>
OOppss. I forgot that it's expensive on ps_status (I think my
favorite platform, FreeBSD, is one of those :().

I do think that pg_stat_activity should be updated, as well as pushing
more of the DEBUG1 progress messages up to INFO, and adding some sort
of timing / statistical info on the create index commands that are run.

Is any of the -hackers community interested, or should I try(!) to
look at the code?

- --
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 512-248-2683 E-Mail: ler(at)lerctr(dot)org
US Mail: 430 Valona Loop, Round Rock, TX 78681-3893
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPV8rRAAoJENC8dtAvA1zmt90IAL7M15RBl6k03Tq18ehUMdos
SKSAT/dSPEaQJx55GIPNy+uE6miiNS8Vo493SJ007hsyob/fuxdhXMfWalrc/qdE
BFsIBNiGJEsy0kyQxhXmXneQurgt1jbntGmCc/rSybd7aDq72fE81G6NaQGXqIOq
FMl3MqQpQuOjL8cCfGgwpsV9paipmlcQTzc52aAcj1Yj15twFySx/P3N18oNX9NP
6JUEgEl6FLP0UQ31roxzbulLR0imoACAThaOOp1swxPREahjkltoU08wk/MeR6xv
hR76is80/16I1hj6DLXwAl6C/Dmmt3ufrKTHKguXJU6RAJI11+05MbSiBIO5wCI=
=rWW2
-----END PGP SIGNATURE-----

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2012-03-07 20:56:21 Re: Checksums, state of play
Previous Message Peter Eisentraut 2012-03-07 20:47:22 Re: Fix PL/Python metadata when there is no result