| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: FDW API |
| Date: | 2011-02-07 08:37:37 |
| Message-ID: | 4D4FAF51.2040809@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.02.2011 08:00, Shigeru HANADA wrote:
> Sorry for late, attached are revised version of FDW API patches which
> reflect Heikki's comments except removing catalog lookup via
> IsForeignTable(). ISTM that the point is avoiding catalog lookup
> during planning, but I have not found when we can set "foreign table
> flag" without catalog lookup during RelOptInfo generation.
In get_relation_info(), you do the catalog lookup anyway and have the
Relation object at hand. Add a flag to RelOptInfo indicating if it's a
foreign table or not, and set that in get_relation_info().
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Itagaki Takahiro | 2011-02-07 09:04:15 | Re: [HACKERS] Issues with generate_series using integer boundaries |
| Previous Message | Greg Smith | 2011-02-07 07:07:41 | Re: Spread checkpoint sync |