| From: | Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: FDW API |
| Date: | 2011-02-08 11:07:09 |
| Message-ID: | 20110208200709.7DED.6989961C@metrosystems.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 07 Feb 2011 09:37:37 +0100
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 07.02.2011 08:00, Shigeru HANADA wrote:
> > Sorry for late, attached are revised version of FDW API patches which
> > reflect Heikki's comments except removing catalog lookup via
> > IsForeignTable(). ISTM that the point is avoiding catalog lookup
> > during planning, but I have not found when we can set "foreign table
> > flag" without catalog lookup during RelOptInfo generation.
>
> In get_relation_info(), you do the catalog lookup anyway and have the
> Relation object at hand. Add a flag to RelOptInfo indicating if it's a
> foreign table or not, and set that in get_relation_info().
Thanks a lot.
Attached is a revised version of foreign_scan patch. This still
requires fdw_handler patch which was attached to the orginal post.
Avoid_catalog_lookup.patch is attached for review purpose.
This patch includes changes for this fix.
Regards,
--
Shigeru Hanada
| Attachment | Content-Type | Size |
|---|---|---|
| avoid_catalog_lookup.patch | application/octet-stream | 4.2 KB |
| 20110208-foreign_scan.patch.gz | application/octet-stream | 12.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2011-02-08 11:57:16 | Re: postponing some large patches to 9.2 |
| Previous Message | Dimitri Fontaine | 2011-02-08 10:51:11 | Re: Extensions support for pg_dump, patch v27 |