From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> |
Subject: | autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
Date: | 2010-12-26 19:14:39 |
Message-ID: | 4D17941F.1040900@wulczer.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 26/12/10 18:17, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sun, Dec 26, 2010 at 8:03 AM, Jan Urbański <wulczer(at)wulczer(dot)org> wrote:
>>> See
>>> https://github.com/wulczer/postgres/commit/44fc42b7708f23483156e4e0e1e321e68b2a7e2d#diff-0
>>> for something that maybe could be used as a basis to autogenerate
>>> errcodes.sgml and plerrcodes.h.
>
>> Interesting. It looks like this might be even easier with perl.
>
> The reason those files aren't autogenerated already is that at the time,
> we had a policy of not requiring perl during a build. Now that that
> restriction has gone down the drain, it might be worth thinking about.
I took a crack at doing that for PL/Python and came up with this piece
of Perl:
I then tried to do the same for plerrcodes.h, but found discrepancies.
For instance:
* errcodes.h defines ERRCODE_L_E_INVALID_SPECIFICATION and plerrcodes.h
has "invalid_locator_specification".
* ERRCODE_INVALID_ARGUMENT_FOR_LOG becomes "invalid_argument_for_logarithm"
* ERRCODE_S_R_E_FUNCTION_EXECUTED_NO_RETURN_STATEMENT is
"function_executed_no_return_statement"
* ... and quite some more like this
Additionally, there's one error missing from plerrcodes.h -
ERRCODE_NONSTANDARD_USE_OF_ESCAPE_CHARACTER does not appear there.
Should we a) forget about autogenerating plerrcodes.h and errcodes.sgml
or b) hardcode some exceptions in the Perl script? Changing condition
names would be a big backwards-compat no-no, I presume.
Cheers,
Jan
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-12-26 19:33:15 | Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
Previous Message | Tom Lane | 2010-12-26 17:17:41 | Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-12-26 19:33:15 | Re: autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
Previous Message | Hitoshi Harada | 2010-12-26 18:19:07 | Re: knngist - 0.8 |