| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Ragnar <gnari(at)hive(dot)is> |
| Subject: | Re: [Review] pgbench duration option |
| Date: | 2008-09-12 08:29:09 |
| Message-ID: | 48CA2855.6060207@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> I wrote:
>> Are people satisfied that the Windows part of the patch is okay?
>
> I went ahead and applied this patch after some trivial stylistic fixes.
> The buildfarm will soon tell us if the WIN32 part of the patch compiles,
> but not whether it works --- would someone double-check the functioning
> of the -T switch on Windows?
Confirmed, it works fine for me. Quick look at the win32 specific code
committed, I see nothing else that would be off in that either (two
handles that are never closed, but there's no point in caring in
pgbench, since it will never happen in a loop)
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-09-12 08:38:41 | Re: Transaction Snapshots and Hot Standby |
| Previous Message | Markus Wanner | 2008-09-12 08:08:56 | Re: Better auth errors from libpq |