From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Rainer Bauer <usenet(at)munnin(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Problem with ControlFileData structure being ABI depe ndent |
Date: | 2007-12-07 16:00:49 |
Message-ID: | 47596E31.4040005@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Dave Page <dpage(at)postgresql(dot)org> writes:
>> Gregory Stark wrote:
>>> An alternative is leaving it in the project file but putting something like
>>> this in c.h:
>
> Put it in win32.h, please. c.h shouldn't get cluttered with
> platform-specific kluges when there's no need for it.
>
> Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h?
Yeah, the fact that addons may then end up partially compiled with and
partially without it being defined. It we just have it error as Greg
suggested, then it will force the authors to define it themselves, and
if they get that wrong it's their fault not ours.
/D
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-12-07 16:03:40 | Re: Possible PostgreSQL 8.3beta4 bug with MD5 authentication in psql? |
Previous Message | Dave Page | 2007-12-07 15:38:37 | Re: Possible PostgreSQL 8.3beta4 bug with MD5 authentication in psql? |
From | Date | Subject | |
---|---|---|---|
Next Message | xeb | 2007-12-07 21:33:47 | [PATCH] automatic integer conversion |
Previous Message | Tom Lane | 2007-12-07 15:37:45 | Re: Problem with ControlFileData structure being ABI depe ndent |