Re: tsearch filenames unlikes special symbols and numbers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>
>> On Mon, Sep 03, 2007 at 07:47:14AM +0100, Gregory Stark wrote:
>>
>>> Actually I think in Windows \ : and . are problems (not allowed more
>>> than one dot in dos).
>> \ and : are problems.
>>
> Is : really a problem, given that the name in question will be appended
> to a known directory's path?
>
The file name shouldn't have a ':' in it. Accessing a path with multiple
':' in it to open a file for reading should just fail normally. So yes,
there should be no problem.

>> . is not a problem. We don't support 16-bit windows anyway, and multiple
>> dots works fine on any system we support.
>>
> I'm not convinced that . is issue-free. On most if not all versions of Unix,
> you are allowed to open a directory as a file and read the filenames it
> contains. While I don't say it'd be easy to manage that through
> tsearch, there's at least a potential for discovering the filenames
> present in . and .. --- how much do we care about that?
>
No more than discovering the file names in any other directory without
using '.' or '..'? If it matters, check to ensure it is a regular file
before opening it?

Cheers,
mark

--
Mark Mielke <mark(at)mielke(dot)cc>