Re: updated WIP: arrays of composites

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: updated WIP: arrays of composites
Date: 2007-05-10 17:04:09
Message-ID: 46435089.7060606@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


>>
>> Attached is my rework of David Fetter's array of composites patch. It
>> has all the agreed modifications and checks, except altering the name
>> mangling.
>>
>>
>
> Here is the latest with the name mangling piece done - it's got quite
> large with the catalog rewrite :-)
>
> It could do with some extra eyeballs - especially the error codes.
>
> I'm not sure if we need to adjust the test in pg_dump.c - maybe we
> should look at using the same test as the backend (typlen == -1) to
> disambiguate real arrays from subscriptable base types.
>

The attached version removes all the places we had NAMEDATALEN - 2
restrictions on object names. If there's no objection I will commit this
shortly, as I think it now does all the previously agreed things.

cheers

andrew

Attachment Content-Type Size
aoc.patch text/x-patch 95.0 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-05-10 19:29:38 Re: updated WIP: arrays of composites
Previous Message Michael Meskes 2007-05-10 10:00:44 Re: ECPG patch to use prepare for improved performance