Re: [HACKERS] \copy (query) delimiter syntax error

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] \copy (query) delimiter syntax error
Date: 2007-02-05 14:42:52
Message-ID: 45C7426C.4080107@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>
>>> The consequence will be, though, that psql will accept a syntax for
>>> "\copy (query) ..." that the corresponding backend command would
>>> reject were we not transforming it. That strikes me as potentially
>>> confusing.
>>>
>>
>> Perhaps. What about plan B: remove the legacy syntax support in \copy?
>> IIRC it has not been documented since 7.2, so maybe we can finally throw
>> it overboard. Thoughts?
>>
>>
>>
>
> I like it for 8.3 - but maybe my present patch would be better for
> 8.2, as it involves less behaviour change.
>

While we decide this issue, which can be worked around in any case, I am
going to commit the part of the patch that nobody has objected to (and
which will fix Michael's original complaint), on HEAD and 8.2 stable, so
we can get some testing going.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gevik Babakhani 2007-02-05 14:53:03 buildfarm fail "cardinal"
Previous Message Bruce Momjian 2007-02-05 14:21:11 Re: VC2005 build and pthreads

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-02-05 15:46:28 Re: [pgsql-patches] Phantom Command IDs, updated patch
Previous Message Tom Lane 2007-02-05 14:19:56 Re: [PATCHES] Fix "database is ready" race condition