Re: [PATCHES] Fix "database is ready" race condition

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
Cc: "Markus Schiltknecht" <markus(at)bluegap(dot)ch>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [PATCHES] Fix "database is ready" race condition
Date: 2007-02-05 14:19:56
Message-ID: 28827.1170685196@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Simon Riggs" <simon(at)2ndquadrant(dot)com> writes:
> My suggestions would be
> 1. "Database system has completed recovery" and
> 2. "Database system is ready to accept connections"

The second was in fact the wording I had in mind, sorry for not being
clear. As to the first, the question is whether a log message at that
specific point has any use. It's not "completion of recovery", exactly,
since we go through that spot whether it's a normal startup or recovery
(and there is another log message when we actually do any WAL replay).
AFAICS it's a fairly randomly chosen place in a long sequence of Things
That Must Happen. Part of the reason Markus is seeing a race condition
is that this isn't the last thing done before the startup subprocess
exits --- see BootstrapMain. So I'm for just getting rid of it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-02-05 14:21:11 Re: VC2005 build and pthreads
Previous Message Simon Riggs 2007-02-05 11:55:26 Re: "Compacting" a relation

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-02-05 14:42:52 Re: [HACKERS] \copy (query) delimiter syntax error
Previous Message Simon Riggs 2007-02-05 11:55:26 Re: "Compacting" a relation