Re: Patch to mark items as static or not used

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to mark items as static or not used
Date: 2006-07-15 13:34:57
Message-ID: 44B8EF01.9000506@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Neil Conway wrote:
> On Sat, 2006-07-15 at 00:05 -0400, Tom Lane wrote:
>
>> The fundamental problem with find_static is that it hasn't got a clue
>> about likely future changes, nor about what we think external add-ons
>> might want
>>
>
> We could annotate the source to indicate that some functions are
> deliberately intended to be externally visible, but not referenced
> within the source tree, and then teach find_static to grok that
> annotation.
>
>

I thought of that, but what if one gets missed? Is the tool worth the
hassle?

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-07-15 15:18:07 Re: Patch to mark items as static or not used
Previous Message Teodor Sigaev 2006-07-15 08:41:39 Re: Patch to mark items as static or not used

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-07-15 15:18:07 Re: Patch to mark items as static or not used
Previous Message Marko Kreen 2006-07-15 11:15:11 Re: [PATCHES] [patch 0/9] annual pgcrypto update