Re: pg_config.h.win32

From: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_config.h.win32
Date: 2001-11-23 04:15:04
Message-ID: 3BFDCD48.E9787C2C@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
>
> Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> writes:
> > pg_config.h generated under cygwin doesn't fit
> > in with native-windows. Of cource pg_config.h.win32
> > doesn't fit in with cygwin either.
>
> Should it? I'm quite content to regard them as separate platforms.
> I don't expect LinuxPPC and Mac OSX to share a pg_config.h, even
> though I run them on the same box.

Yes but the current native-windows stuff doesn't seem
valuable to keep a separate source tree.

>
> I'm also not seeing why #including one file in the other would make
> that problem better?

??? I'm changing my pg_config.h locally in reality
like as follows.

#ifdef WIN32
#include "pg_config.h.win32"
#else
.
. (the original content of pg_config.h)
.
#endif /* WIN32 */

There's no problem to compile under both cygwin
and native-windows. It's much safer than replacing
pg_config.h.win32 and the original pg_config.h each
time.

regards,
Hiroshi Inoue

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-11-23 04:26:16 Re: Unescaped new lines in postgres
Previous Message Lamar Owen 2001-11-23 04:08:36 Re: v7.2b3 packaged, but not announced beyond here yet ...