Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the
Date: 2009-01-07 20:20:24
Message-ID: 3659.1231359624@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> We should take a second look at the usage of debug_query_string,
>> particularly the recently added current_query() SQL function.

> I looked at the use of 'debug_query_string'; I didn't see how
> current_query() could access the more concise query string that is
> stored in various structures (comment added); it works now by accessing
> the global variable 'debug_query_string'.

The alternative I was envisioning was to have it look at the
ActivePortal's query string. However, if you prefer to define the
function as returning the current client query, it's fine as-is.
We should make sure the documentation explains it like that however.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-01-07 20:38:56 pgsql: Insert conditional SPI_push/SPI_pop calls into InputFunctionCall,
Previous Message Bruce Momjian 2009-01-07 19:53:54 Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Inoue 2009-01-07 21:19:25 Re: [BUGS] BUG #4186: set lc_messages does not work
Previous Message Bruce Momjian 2009-01-07 19:53:54 Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the