Re: pgsql: Fix whitespace issues found by git diff --check, add gitattribut

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix whitespace issues found by git diff --check, add gitattribut
Date: 2013-11-11 15:26:18
Message-ID: 30018.1384183578@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Fix whitespace issues found by git diff --check, add gitattributes
> Set per file type attributes in .gitattributes to fine-tune whitespace
> checks. With the associated cleanups, the tree is now clean for git

Hmm, I thought the .gitattributes file would prevent this:

$ git diff --staged --check
src/test/regress/expected/join.out:3110: trailing whitespace.
+ q1 | q2 | f1 | ff

Is there something I have to do to configure git to honor the file?

(In case it matters, this is git 1.7.1, which is what Red Hat is
shipping these days in RHEL6.)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-11-11 15:43:11 pgsql: Re-allow duplicate aliases within aliased JOINs.
Previous Message Magnus Hagander 2013-11-11 14:01:00 pgsql: Don't abort pg_basebackup when receiving empty WAL block

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2013-11-11 15:31:25 Re: Another bug(?) turned up by the llvm optimization checker
Previous Message Ishaya Bhatt 2013-11-11 14:49:58 Re: Datatyp of a column