From: | Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)hub(dot)org |
Subject: | Re: pg_dump of regression (again) |
Date: | 2000-09-15 01:22:01 |
Message-ID: | 3.0.5.32.20000915112201.02809670@mail.rhyme.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 11:44 14/09/00 -0400, Tom Lane wrote:
>
>> The problem is the "numeric[]" type.
>
>numeric[] is a correct display of the type (and more intelligible than
>_numeric IMHO), but quoting it is not correct. If you are feeding the
>output of format_type through something that believes it's quoting a
>single identifier, you are going to have lots of problems. It looks
>to me like format_type will supply quotes when needed, so you shouldn't
>add more.
You're quite right - I left the original pg_dump ID quoting stuff in place.
>So you have to give the raw type name, no fancy fandangoes ...
OK - I'll use typname in CREATE AGGREGATE, and see how it hangs together.
Do you know if the type parser is invoked in function declarations? If not
I probably just need to limit use of format_type to table declarations.
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
From | Date | Subject | |
---|---|---|---|
Next Message | Hiroshi Inoue | 2000-09-15 01:40:13 | RE: current is broken |
Previous Message | Philip Warner | 2000-09-15 01:01:24 | Re: Dumping views as views? |