Re: [HACKERS] plperl and pltcl installcheck targets

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] plperl and pltcl installcheck targets
Date: 2005-05-12 13:50:28
Message-ID: 29950.1115905828@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> Not entirely. We should move around the test sql script and the expected
>> result file so that the file structure looks exactly like one of the
>> test-enabled contrib modules.

> That's pretty much what I thought I did except that I put it all in the
> test subdir. Frankly, I think that's a better arrangement - having
> cube/cube.sql and cube/sql/cube.sql is confusing - putting test stuff in
> a test subdirectory makes its purpose clear.

[ shrug... ] I don't see a good argument for making the PLs have a
directory layout that is different from the one in use in contrib.
If you want to argue that all of the contrib subdirectories should
be changed, bring it up in -hackers; but it is hard to get excited
about.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-05-12 14:09:23 Re: implementing NOTIFY with message parameter
Previous Message Andrew Dunstan 2005-05-12 13:40:40 Re: [HACKERS] plperl and pltcl installcheck targets

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-05-12 14:28:43 Re: lastval()
Previous Message Andrew Dunstan 2005-05-12 13:40:40 Re: [HACKERS] plperl and pltcl installcheck targets