Re: optimizing CleanupTempFiles

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: optimizing CleanupTempFiles
Date: 2008-09-17 21:54:49
Message-ID: 29105.1221688489@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Ah -- like this?

+1, but there are two kinds of temp files in that module, and only
one of them is relevant here. Call it something like
have_xact_temporary_files to make things clearer.

I concur that the explicit test on SizeVfdCache > 0 is a waste of
effort, too. It'll nearly always be true anyway.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-09-17 22:07:06 Re: optimizing CleanupTempFiles
Previous Message Alvaro Herrera 2008-09-17 21:40:25 Re: optimizing CleanupTempFiles