| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: optimizing CleanupTempFiles |
| Date: | 2008-09-17 23:43:39 |
| Message-ID: | 20080917234339.GJ3855@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Ah -- like this?
>
> +1, but there are two kinds of temp files in that module, and only
> one of them is relevant here. Call it something like
> have_xact_temporary_files to make things clearer.
Ok, so that's what I called it.
Simon wrote:
> if test should include
> || isProcExit
>
> so you don't skip non-transactional temp files at proc exit when there
> weren't any created in the last transaction.
Yep, I noticed that too. Thanks.
Should I backpatch this to 8.3?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| Attachment | Content-Type | Size |
|---|---|---|
| cleanuptemp-speedup-2.patch | text/x-diff | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-09-17 23:46:17 | Re: optimizing CleanupTempFiles |
| Previous Message | Simon Riggs | 2008-09-17 22:18:02 | Re: optimizing CleanupTempFiles |