Re: Patch for fixing a few memory leaks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Teodor Sigaev <teodor(at)stack(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch for fixing a few memory leaks
Date: 2001-10-04 19:16:24
Message-ID: 286.1002222984@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Teodor Sigaev <teodor(at)stack(dot)net> writes:
> Patch fix memory leaks in src/backend/utils/fmgr/dfmgr.c .

Applied, thanks. (Looks like the leaks were introduced fairly
recently by the dynamic-search-path feature.)

> Tom, I want to notice that initGISTstate is called for every inserting
> value (for each row). I think it's not good, because this function
> called 'fmgr_info' 7 times. 'fmgr_info' call a
> 'load_external_function' with execution of sequence search on library
> name. Any suggestion?

fmgr_info shouldn't be all that expensive; I'm not really inclined to
worry about it. Do you have evidence to the contrary?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Lockhart 2001-10-04 20:13:17 Re: [HACKERS] Timestamp, fractional seconds problem
Previous Message Bruce Momjian 2001-10-04 19:16:02 Re: Patch for fixing a few memory leaks