Re: Patch for fixing a few memory leaks

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Teodor Sigaev <teodor(at)stack(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Patch for fixing a few memory leaks
Date: 2001-10-04 19:16:02
Message-ID: 200110041916.f94JG2513079@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Patch applied. Thanks.

> Patch fix memory leaks in src/backend/utils/fmgr/dfmgr.c .
> This leaks is very significant with massive update/insert tables with gist
> indexes in one transaction or with following sequence of commands:
> 1. COPY in table large number of row
> 2. CREATE GiST index on table
> 3. VACUUM ANALYZE
> On third step postgres eats very big number of memory.
> This patch fix it.
>
> BTW
> Tom, I want to notice that initGISTstate is called for every inserting value
> (for each row). I think it's not good, because this function called 'fmgr_info'
> 7 times. 'fmgr_info' call a 'load_external_function' with execution of sequence
> search on library name. Any suggestion?
>
> --
> Teodor Sigaev
> teodor(at)stack(dot)net
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-10-04 19:16:24 Re: Patch for fixing a few memory leaks
Previous Message Laurette Cisneros 2001-10-04 18:59:44 Re: Timestamp, fractional seconds problem