From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Move Assert() definitions to c.h |
Date: | 2013-02-04 15:36:37 |
Message-ID: | 27041.1359992197@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> This seems a bit odd. Why didn't you move all of postgres.h's section 3
>> into the new section in c.h? The couple of declarations you left there
>> are neither useful nor intelligible on their own.
> One slight problem in this line:
> extern PGDLLIMPORT bool assert_enabled;
> This appears in line 622 in c.h, but PGDLLIMPORT is not defined till
> line 965. So we would have to put that declaration below section 9
> "system specific hacks". Having a separate
> #if defined(USE_ASSERT_CHECKING) && !defined(FRONTEND)
> section seems weird.
Ah. Okay, let's leave it alone then. It might be worth adding a
comment though that says these declarations are support for the
Assert-related macros in c.h.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2013-02-04 16:44:46 | pgsql: Reset vacuum_defer_cleanup_age to PGC_SIGHUP. |
Previous Message | Alvaro Herrera | 2013-02-04 15:32:06 | Re: pgsql: Move Assert() definitions to c.h |