Re: Solaris testers wanted for strxfrm() behavior

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Mlodgenski <jimmy76(at)gmail(dot)com>
Subject: Re: Solaris testers wanted for strxfrm() behavior
Date: 2015-06-30 13:45:08
Message-ID: 25845.1435671908@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Sun, Jun 28, 2015 at 07:00:14PM -0400, Tom Lane wrote:
>> Another idea would be to make a test during postmaster start to see
>> if this bug exists, and fail if so. I'm generally on board with the
>> thought that we don't need to work on systems with such a bad bug,
>> but it would be a good thing if the failure was clean and produced
>> a helpful error message, rather than looking like a Postgres bug.

> Failing cleanly on unpatched Solaris is adequate, agreed. A check at
> postmaster start isn't enough, because the postmaster might run in the C
> locale while individual databases or collations use problem locales. The
> safest thing is to test after every setlocale(LC_COLLATE) and
> newlocale(LC_COLLATE). That's once at backend start and once per backend per
> collation used, more frequent than I would like. Hmm.

I was thinking more along the lines of making a single test by momentarily
switching into a known-buggy locale.

However, your results here imply that there are or were more than one bug
with this symptom, which may make a catchall test impossible.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shulgin, Oleksandr 2015-06-30 14:42:44 Re: Streaming replication for psycopg2
Previous Message Tom Lane 2015-06-30 13:38:23 9.5 branch splitoff