| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeremy Drake <pgsql(at)jdrake(dot)com> |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Mark Dilger <pgsql(at)markdilger(dot)com> |
| Subject: | Re: patch adding new regexp functions |
| Date: | 2007-03-22 04:42:23 |
| Message-ID: | 25643.1174538543@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Jeremy Drake <pgsql(at)jdrake(dot)com> writes:
> On Wed, 21 Mar 2007, Tom Lane wrote:
>> By and large we tend to hard-wire those properties too, eg there are
>> plenty of places that do things like this:
> So, what action (if any) should be taken? Should all (or some) of these
> values be hardcoded, or should the current calls to determine them be left
> in place?
I'd vote for making this new code look like the rest of it, to wit
hardwire the values. As-is, you're expending code space and cycles
on flexibility that's entirely illusory --- if we ever decided to
change these properties of TEXT, we'd have way more work to do than
just fixing the new regexp functions.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-03-22 04:50:20 | Re: Proposal: Adding JIS X 0213 support |
| Previous Message | Tom Lane | 2007-03-22 04:33:43 | Re: [HACKERS] Stats processor not restarting |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Drake | 2007-03-22 05:17:03 | Re: patch adding new regexp functions |
| Previous Message | Tom Lane | 2007-03-22 04:33:43 | Re: [HACKERS] Stats processor not restarting |