Re: [HACKERS] Stats processor not restarting

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Stats processor not restarting
Date: 2007-03-22 04:33:43
Message-ID: 25538.1174538023@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Not really, but maybe it would be sensible to reset last_pgstat_start_time
>> when doing a database-wide restart?

> You mean like this, attached?

I'd be fairly surprised if resetting the variable in the child process
had any effect on the postmaster...

I think a correct fix would involve exposing either the variable or a
routine to zero it from pgstat.c, and having postmaster.c do that at
the points where it intentionally SIGQUITs the stats collector.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-03-22 04:42:23 Re: patch adding new regexp functions
Previous Message Tatsuo Ishii 2007-03-22 04:06:00 Proposal: Adding JIS X 0213 support

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-03-22 04:42:23 Re: patch adding new regexp functions
Previous Message Bruce Momjian 2007-03-22 02:24:38 Re: [PATCHES] As proposed the complete changes to pg_trigger and pg_rewrite