Re: Add ENCODING option to COPY

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add ENCODING option to COPY
Date: 2011-02-04 16:52:04
Message-ID: 24297.1296838324@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> writes:
> 2011/2/5 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> Yeah, putting backend-only stuff into that header is a nonstarter.

> Do you mean you think it' all right to define
> pg_cached_encoding_conversion() in pg_conversion_fn.h?

That seems pretty random too. I still think you've designed this API
badly and it'd be better to avoid exposing the FmgrInfo to callers
by letting the function manage the cache internally.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-02-04 16:54:48 Re: ALTER EXTENSION UPGRADE, v3
Previous Message David E. Wheeler 2011-02-04 16:48:08 Re: ALTER EXTENSION UPGRADE, v3