Re: plpgsql raise - parameters can be expressions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz>, pgsql-patches(at)postgresql(dot)org
Subject: Re: plpgsql raise - parameters can be expressions
Date: 2005-06-14 04:50:45
Message-ID: 24042.1118724645@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> ... One question is whether we should make use of
> exec_eval_expr() by representing the RAISE parameter list as a list of
> expressions (each of which would likely be simple enough to evaluate via
> ExecEvalExpr()), or whether we want to extend exec_eval_expr() to handle
> expressions that yield multiple attributes.

I'd lean to the former myself --- which actually does suggest that this
patch is not ready for application yet, because it banks on the
assumption that "x,y,z" should be treated as a single expression.

Now that I think about it, the amount of overhead in that assumption is
pretty high: there's tuple construction and deconstruction involved,
no matter how simple the individual datatypes are. So I'd definitely
prefer to see it changed.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-06-14 06:49:51 Re: plpgsql raise - parameters can be expressions
Previous Message Neil Conway 2005-06-14 04:44:42 Re: plpgsql raise - parameters can be expressions