| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, buschmann(at)nidsa(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12 |
| Date: | 2019-10-16 14:33:43 |
| Message-ID: | 20191016143343.7tq374yllq3zoglv@development |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Oct 16, 2019 at 03:26:42PM +0200, Tom Lane wrote:
>I wrote:
>> Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>>> I've just committed and pushed both fixes after some minor corrections.
>
>> Not quite right in 9.6 and before, according to crake. Looks like
>> some issue with the CppAsString2'd constants? Did we even have
>> CppAsString2 that far back?
>
>Yeah, we did. On closer inspection I suspect that we need to #include
>some other file to get the RELKIND_ constants in the old branches.
>
Yeah, the pg_class.h catalog was missing on pre-10 relases. It compiled
just fine, so I haven't noticed that during the backpatching :-(
Fixed, let's see if the buildfarm is happy with that.
regads
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ivan Pantić | 2019-10-16 16:01:58 | pg_restore creates duplicate records when used with --role parameter |
| Previous Message | Tomas Vondra | 2019-10-16 13:41:17 | Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2019-10-16 14:41:19 | Re: configure fails for perl check on CentOS8 |
| Previous Message | Heikki Linnakangas | 2019-10-16 13:51:49 | Re: Questions/Observations related to Gist vacuum |