Re: Dynamically adding index types (was GIT indexes)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dynamically adding index types (was GIT indexes)
Date: 2007-09-19 14:37:30
Message-ID: 20165.1190212650@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> We're able to dynamically add AMs in the way you suggest, but there is
> no way to alter the RMgrTable to either add a new RM or re-assign one of
> the unused RMs.

Hmmm...

> 1. Remove the "Const" in front of RmgrTable in rmgr.c. That would allow
> re-assignment of the two existing unused RMs.

Useless, as there's no way for an add-on AM to cause the value to be
changed before recovery begins.

> 2. Create a new catalog table pg_rm and some brief machinery to populate
> the RmgrTable from pg_rm. That would allow dynamically adding RMs.

Also useless --- what if pg_rm is damaged or missing? Even if it's
there, how would recovery be able to tell which rows are valid? We
certainly don't want it trying to do pg_clog probes.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Decibel! 2007-09-19 14:53:29 Re: First steps with 8.3 and autovacuum launcher
Previous Message Tom Lane 2007-09-19 13:08:09 Re: Open issues for HOT patch