Re: BUG #12755: pg_upgrage creates potentially dangerous delete_old_cluster.bat

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: toni(dot)helenius(at)syncrontech(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #12755: pg_upgrage creates potentially dangerous delete_old_cluster.bat
Date: 2015-02-10 18:11:16
Message-ID: 20150210181116.GD18557@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Feb 10, 2015 at 10:44:41AM +0000, toni(dot)helenius(at)syncrontech(dot)com wrote:
> The following bug has been logged on the website:
>
> Bug reference: 12755
> Logged by: Toni Helenius
> Email address: toni(dot)helenius(at)syncrontech(dot)com
> PostgreSQL version: 9.4.1
> Operating system: Windows 7
> Description:
>
> pg_upgrage creates potentially dangerous delete_old_cluster.bat. RMDIR
> without quotes.
>
> RMDIR /s/q C:\Program Files\PostgreSQL\9.3\data
>
> Executes as:
> RMDIR /s/q C:\Program
>
> Needs quotes!!

Wow, very good point. Not sure why this problem was not reported
before. Patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
pg_upgrade_rm.diff text/x-diff 2.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message dean deloach 2015-02-10 18:56:23 Re: BUG #12749: WARNING: unrecognized node type: 701
Previous Message dean deloach 2015-02-10 15:27:29 Re: BUG #12749: WARNING: unrecognized node type: 701