| From: | 'Andres Freund' <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Paragon Corporation <lr(at)pcorp(dot)us>, 'Robert Haas' <robertmhaas(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #11902: PostgreSQL 9.5 crashes on alter table in function |
| Date: | 2014-11-06 21:24:12 |
| Message-ID: | 20141106212412.GB12525@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2014-11-06 16:15:15 -0500, Tom Lane wrote:
> "Paragon Corporation" <lr(at)pcorp(dot)us> writes:
> > I can pull from latest git and then run the tests again if you think the
> > issue is fixed.
>
> No, the given test case crashes HEAD just fine. Robert seems to have
> changed the invariants around the trigger query stack in some inconsistent
> fashion.
I think it's just a missing
if (depth < afterTriggers.maxquerydepth)
continue;
or similar in AfterTriggerPendingOnRel, inside the second loop.
Alternatively we could make the for something like
depth = 0; depth <= Min(afterTriggers.query_depth, afterTriggers.query_depth - 1)
but that doesn't seem prettier.
Robert?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2014-11-06 21:37:01 | Re: [BUGS] ltree::text not immutable? |
| Previous Message | Jim Nasby | 2014-11-06 21:21:10 | Re: [BUGS] BUG #11867: Strange behaviour with composite types after resetting database tablespace |