Re: pgsql: Allow units to be specified in relation option setting value.

On 2014-08-28 14:11:33 +0200, Andres Freund wrote:
> Hi,
>
> On 2014-08-28 07:15:35 +0000, Fujii Masao wrote:
> > Allow units to be specified in relation option setting value.
> >
> > This introduces an infrastructure which allows us to specify the units
> > like ms (milliseconds) in integer relation option, like GUC parameter.
> > Currently only autovacuum_vacuum_cost_delay reloption can accept
> > the units.
>
> This apparently broke pg_upgrade. I've not checked what's up there.
>
> See
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2014-08-28%2007%3A16%3A04
> and many others.

The specific error is an unquoted 80ms in WITH
(autovacuum_vacuum_cost_delay=80ms);

Independent of that being fixable with some quoting or such, I'm a bit
doubtful about unconditionally adding the ms here. Won't that make it
unnecessarily hard to get 9.5 dumps into <9.5? I know that we don't make
any promises, but it mostly works nonetheless. And this doesn't seem
worth the breakage.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services