| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FastPathStrongRelationLocks still has an issue in HEAD |
| Date: | 2014-04-07 14:20:22 |
| Message-ID: | 20140407142022.GB4161@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-04-07 10:06:07 -0400, Robert Haas wrote:
> I'm a bit suspicious of the patches to
> static-ify stuff, since that might cause the compiler to think it
> could move things across function calls that it hadn't thought
> move-able before, but FastPathStrongLocks references would seem to be
> the obvious candidate for that, and volatile-izing it ought to have
> fixed it. I would think.
Hm. It generally might be interesting to get a few !X86 buildfarms
running builds with LTO enabled. That might expose some dangerous
assumptions more easily.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-04-07 14:26:08 | Re: Windows exit code 128 ... it's baaack |
| Previous Message | Mike Blackwell | 2014-04-07 14:13:16 | Re: tds_fdw for Sybase and MS SQL Server |