Re: [GENERAL] Can't Build 7.3.4 on OS X

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Karppinen <karppinen(at)pobox(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [GENERAL] Can't Build 7.3.4 on OS X
Date: 2003-09-23 17:28:48
Message-ID: 20128.1064338128@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-general pgsql-hackers

Marko Karppinen <karppinen(at)pobox(dot)com> writes:
>> 3. What's with the WITHOUT_DARWIN_BUNDLE_LOADER hack for ecpg?

> The linker doesn't like symbols that are defined both in the shared
> object
> that's being linked and the bundle_loader binary. ecpg contains symbols
> that are in the postgresql binary, too, leading to the link failing with
> multiply-defined errors.

> The easiest way for me to fix this -- I don't really know my way around
> the
> source base -- was to specify by hand that the -bundle-loader flag isn't
> used on these occasions.

I think the right fix is that "-bundle-loader /path/to/postgres" should
be included in the link only for shlibs that are intended to be loaded
into the backend. Otherwise you are lying to the linker; the mere fact
that it fails to fail doesn't make it the right thing to do. (As an
example of how it could go wrong, what if there is a real undefined
symbol problem in libpq, but it happens to match some backend symbol?)

We used to have a similar requirement for some other platforms (AIX
I think), and there was a macro named something like BE_SHLIBS to
include the right platform-dependent stuff for such shlibs. Not sure
what happened to it. Peter, do you remember that?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2003-09-23 18:35:13 Re: [GENERAL] Can't Build 7.3.4 on OS X
Previous Message Marko Karppinen 2003-09-23 16:51:53 Re: [GENERAL] Can't Build 7.3.4 on OS X

Browse pgsql-general by date

  From Date Subject
Next Message Marten G Mickos 2003-09-23 17:33:15 Re: About GPL and proprietary software
Previous Message Andrew Sullivan 2003-09-23 17:28:04 Re: OT: HEADS-UP: viral storm out there

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2003-09-23 18:11:26 website announcement for 7.4 beta
Previous Message Tom Lane 2003-09-23 17:16:35 Re: pg_dump doesn't dump binary compatible casts