Re: pg_upgrade patches applied

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> That isn't going to work. At least not unless you start trying to force
> >> roles to have the same OIDs in the new installation.
>
> > If so I can use the CREATE ROLE ... SYSID clause when doing a binary
> > upgrade.
>
> Oh, I had forgotten we still had that wart in the grammar.
> It doesn't actually work:
>
> else if (strcmp(defel->defname, "sysid") == 0)
> {
> ereport(NOTICE,
> (errmsg("SYSID can no longer be specified")));
> }
>
> Not sure if it's better to try to make that work again than to add
> another hack in pg_upgrade_support. On the whole that's a keyword
> I'd rather see us drop someday soon.

OK, let me work on adding it to pg_upgrade_support. Glad you saw this.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +