Re: pg_upgrade versus MSVC build scripts

Tom Lane wrote:
> A look at the MSVC buildfarm members shows that they are not building
> most of the files added to contrib/pg_upgrade. The reason seems to be
> that that module tries to build both an executable program *and* a
> shared library, which it does by dint of setting both PROGRAM and
> MODULES in its Makefile. Now that is a dirty hack that is nowhere
> documented to work, and in fact the pgxs documentation explicitly says
> not to do that. It accidentally fails to fail, at the moment, because
> of the way pgxs.mk is set up, and because the OBJS variable is only
> needed for one of these targets. But the MSVC build scripts aren't
> expecting this and evidently disregard PROGRAM after they see MODULES.

Yeah, I was stumped by the problem of creating an executable and shared
object and didn't find any usage of this case. Leave it me to find a
loop-hole. ;-)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com