Re: building pg_dump doesn't work

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: building pg_dump doesn't work
Date: 2009-03-04 16:11:18
Message-ID: 20090304161118.GJ12851@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera wrote:
> Tom Lane wrote:

> > What I'd suggest is something similar to the design of the errcodes.h
> > header: create a header file containing just the list of PG_KEYWORD
> > macro calls, and have the different users #include it after defining
> > that macro appropriately. Having .c files include other .c files is
> > usually best avoided on least-surprise grounds.
>
> Seems doable.

Attached.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment Content-Type Size
pgdump-parser-dep-3.patch text/x-diff 53.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-03-04 16:37:06 Re: Review: B-Tree emulation for GIN
Previous Message Alvaro Herrera 2009-03-04 16:03:19 Re: building pg_dump doesn't work