Re: building pg_dump doesn't work

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: building pg_dump doesn't work
Date: 2009-03-04 16:03:19
Message-ID: 20090304160319.GI12851@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas wrote:
> Alvaro Herrera wrote:

>> /*
>> + * We don't want to include the gram.h file on frontend builds, except ECPG, so
>> + * leave out the second struct member in that case.
>> + */
>> + #if !defined FRONTEND || defined ECPG_COMPILE
>> + #define PG_KEYWORD(a,b,c) {a,b,c}
>> + #else
>> + #define PG_KEYWORD(a,b,c) {a,c}
>> + #endif
>
> Doesn't that put 'c' into the wrong field in ScanKeyword struct? It only
> compiles because both 'value' and 'category' are int16.

No, because I had the header with the second field omitted too.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-03-04 16:11:18 Re: building pg_dump doesn't work
Previous Message Hans-Jürgen Schönig 2009-03-04 15:41:01 Re: SYNONYMs revisited