| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Fix for compiler warning in reloptions.c |
| Date: | 2009-01-06 03:16:50 |
| Message-ID: | 200901060316.n063Got25929@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > The attached applied patch prevents a compiler warning; the compiler
> > doesn't know about our elog(ERROR) exit case.
>
> Hmm, I don't like your fix; ISTM it would be better to set the variable
> only in the default: case (or maybe change the "break" for a "return").
Agreed, I used the 'default' idea, attached, applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/diff | text/x-diff | 908 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2009-01-06 03:54:14 | Re: dblink vs SQL/MED - security and implementation details |
| Previous Message | Tatsuo Ishii | 2009-01-06 03:14:59 | Re: contrib Japanese README |