Re: Fix for compiler warning in reloptions.c

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Fix for compiler warning in reloptions.c
Date: 2009-01-06 03:06:45
Message-ID: 20090106030645.GK7345@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> The attached applied patch prevents a compiler warning; the compiler
> doesn't know about our elog(ERROR) exit case.

Hmm, I don't like your fix; ISTM it would be better to set the variable
only in the default: case (or maybe change the "break" for a "return").

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-01-06 03:06:47 Re: version() output vs. 32/64 bits
Previous Message Tatsuo Ishii 2009-01-06 03:00:16 contrib Japanese README