Re: Lessons from commit fest

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chris Browne <cbbrowne(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Lessons from commit fest
Date: 2008-04-17 00:19:43
Message-ID: 200804170019.m3H0JhR16400@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > I am reviewing the psql wrap patch and just used pgindent today to clean
> > > it up. (pgindent did not add any extra spacing changes.) Patch
> > > reviewers should probably be able to run pgindent.
> >
> > Well, that means nobody in the world can review except you, because
> > nobody else has ever reported success in duplicating your pgindent
> > results. I know I haven't been able to.
> >
> > If you really believe the above then you need to try a bit harder
> > to find a portable version of indent that we all can use.
>
> The source code of pgindent I use is on our ftp site. find_typedefs
> should now work on Linux as well as BSD. Not sure what else would be a
> problem.

Also I can put up a web page where you can upload or email your C file
and get a formatted version back.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-17 00:20:59 Re: count(*) performance improvement ideas
Previous Message Bruce Momjian 2008-04-17 00:17:41 Re: Lessons from commit fest