| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Chris Browne <cbbrowne(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Lessons from commit fest |
| Date: | 2008-04-17 00:17:41 |
| Message-ID: | 200804170017.m3H0HfZ16166@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I am reviewing the psql wrap patch and just used pgindent today to clean
> > it up. (pgindent did not add any extra spacing changes.) Patch
> > reviewers should probably be able to run pgindent.
>
> Well, that means nobody in the world can review except you, because
> nobody else has ever reported success in duplicating your pgindent
> results. I know I haven't been able to.
>
> If you really believe the above then you need to try a bit harder
> to find a portable version of indent that we all can use.
The source code of pgindent I use is on our ftp site. find_typedefs
should now work on Linux as well as BSD. Not sure what else would be a
problem.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2008-04-17 00:19:43 | Re: Lessons from commit fest |
| Previous Message | Tom Lane | 2008-04-17 00:15:54 | Re: Lessons from commit fest |