| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, ishii(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: pgbench on mingw needs fflush |
| Date: | 2007-03-13 09:06:40 |
| Message-ID: | 20070313090640.GF22636@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Tue, Mar 13, 2007 at 05:09:15PM +0900, ITAGAKI Takahiro wrote:
>
> Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>
> > Can we distinguish mingw case from others so that we could ifdef out
> > the extra fflush()?
> > > The buffered stderr might be a bug of mingw
>
> After a little research, I found that MSDN says the buffered stderr is
> a specifications on Windows somehow, not a bug.
>
> setvbuf() is better solution for the problem.
> This is more simple and no need to use ifdef.
I was just going to suggest this, because this is what we already use in
the backend (src/backend/main/main.c).
Applied, but with the #ifdefs, because that's cleaner and that's also
how we do it in the backend.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joachim Wieland | 2007-03-13 10:54:18 | Re: guc patch: Make variables fall back to default values |
| Previous Message | Gregory Stark | 2007-03-13 08:22:17 | Re: guc patch: Make variables fall back to default values |