| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: seahorse again failing |
| Date: | 2006-08-22 14:44:28 |
| Message-ID: | 20060822144428.GB1814@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 22, 2006 at 10:19:38AM -0400, Tom Lane wrote:
> > It may be a good idea to put a elog(LOG) with the error code in the
> > failure path of AllocateFile.
>
> That seems like a plan to me. I had been thinking of making
> win32error.c itself log the conversions, but that would not provide any
> context information. AllocateFile could log the file name along with
> the code, which should be enough info to associate a particular log
> entry with the actual failure.
Would it be possible to get errcode_for_file_access() to report the
results of GetLastError() for windows, or would that roduce spurious
results. At DEBUG lavel maybe?
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-22 14:48:07 | Re: Queries joining views |
| Previous Message | Stefan Kaltenbrunner | 2006-08-22 14:38:23 | Re: seahorse again failing |